Purges old accounts hash cache dirs #33183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
work in progress
brooksprumo
force-pushed
the
accounts-hash-cache/remove-old-dirs
branch
from
de63526 to
f7e97d4
Compare
brooksprumo
added
CI
Codecov Report
@@ Coverage Diff @@
## master #33183 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 789 789
Lines 213733 213742 +9
=========================================
- Hits 175181 175170 -11
- Misses 38552 38572 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
(cherry picked from commit acd7ad9)
brooksprumo
added a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit acd7ad9)
brooksprumo
added a commit
that referenced
this pull request
Sep 14, 2023
(cherry picked from commit acd7ad9) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts hash cache dirs have been renamed/removed in #33164 and #33181. We do not want the old directories remaining on the filesystem taking up space.
A node operator could manually remove these old directories, but an automatic method is more user friendly.
Summary of Changes
Purges old accounts hash cache dirs